ResourceManager: Minor logging and implementation refinements#50
Open
nigels-com wants to merge 1 commit intoCalcProgrammer1:masterfrom
Open
ResourceManager: Minor logging and implementation refinements#50nigels-com wants to merge 1 commit intoCalcProgrammer1:masterfrom
nigels-com wants to merge 1 commit intoCalcProgrammer1:masterfrom
Conversation
nigels-com
commented
May 17, 2025
| if(i2c_dimm_device_detectors[i2c_detector_idx].dimm_type == dimm_type && | ||
| is_jedec_in_slots(slots, i2c_dimm_device_detectors[i2c_detector_idx].jedec_id)) | ||
| { | ||
| detection_string = i2c_dimm_device_detectors[i2c_detector_idx].name.c_str(); |
Author
There was a problem hiding this comment.
It didn't seem harmful to lift this out of the if block.
But I'm new to the codebase, and since detection_string is visible elsewhere, thought I should call it out.
CalcProgrammer1
force-pushed
the
master
branch
from
bbd83c9 to
269e7c6
Compare
CalcProgrammer1
force-pushed
the
master
branch
from
cd7b90e to
90e4da1
Compare
CalcProgrammer1
force-pushed
the
master
branch
2 times, most recently
from
ceb9ff0 to
f948d6e
Compare
CalcProgrammer1
force-pushed
the
master
branch
from
79b7751 to
ba91bf4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I felt that having a
I2CDIMMDeviceDetectorBlockreference clarified this loop.